TilemapChunk single quad; TileData (color/visibility) #19924
+224
−223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnerPetzold
force-pushed
the
tilemap-chunk-single-quad
branch
from
058304a to
edbc343
Compare
alice-i-cecile
added
C-Feature
|
It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note. Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes. |
ConnerPetzold
force-pushed
the
tilemap-chunk-single-quad
branch
from
edbc343 to
5e026ef
Compare
copygirl
reviewed
Jul 9, 2025
ConnerPetzold
force-pushed
the
tilemap-chunk-single-quad
branch
3 times, most recently
from
aa512c7 to
606bcb4
Compare
IceSentry
reviewed
Jul 13, 2025
IceSentry
approved these changes
Jul 13, 2025
ConnerPetzold
force-pushed
the
tilemap-chunk-single-quad
branch
from
606bcb4 to
e9c1e1a
Compare
atlv24
reviewed
Jul 14, 2025
crates/bevy_sprite/src/tilemap_chunk/tilemap_chunk_material.wgsl
Outdated
Show resolved
Hide resolved
| @@ -60,10 +54,36 @@ pub struct TilemapChunk { | |||
| pub alpha_mode: AlphaMode2d, | |||
| } | |||
|
|
|||
| #[derive(Clone, Copy, Debug)] | |||
| } | ||
|
|
||
| impl TileData { | ||
| pub fn from_index(index: u16) -> Self { |
There was a problem hiding this comment.
Doc strings, ideally linking to where you get this index from.
| fn default() -> Self { | ||
| Self { | ||
| tileset_index: 0, | ||
| color: Color::WHITE, |
There was a problem hiding this comment.
Why a default of white rather than black or our standard missing data magenta?
There was a problem hiding this comment.
I think white is the standard default for tinting, since you're effectively leaving the original pixel color untouched. Maybe it makes sense for it to be optional though?
alice-i-cecile
requested changes
Jul 16, 2025
alice-i-cecile
added
S-Waiting-on-Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Testing